changed all usages of 'admin' as a password to something different #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=========================================
Coverage 74.25% 74.25%
Complexity 884 884
=========================================
Files 133 133
Lines 5791 5791
Branches 708 708
=========================================
Hits 4300 4300
Misses 1181 1181
Partials 310 310 ☔ View full report in Codecov by Sentry. |
toepkerd
requested review from
lezzago,
qreshi,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90 and
AWSHurneyt
as code owners
AWSHurneyt
approved these changes
Jan 31, 2024
bowenlan-amzn
approved these changes
Jan 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
) Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> (cherry picked from commit a632b47) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes stop common-utils from using 'admin' as a password in any security plugin related workflows
Issues Resolved
#579
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.