Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupId = org.opensearch.plugin #589

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

prudhvigodithi
Copy link
Member

Signed-off-by: prudhvigodithi pgodithi@amazon.com

Description

add groupID = org.opensearch.plugin

Issues Resolved

#534

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from a team October 12, 2022 20:33
@prudhvigodithi prudhvigodithi added backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 12, 2022
@prudhvigodithi prudhvigodithi changed the title add groupID = org.opensearch.plugin add groupId = org.opensearch.plugin Oct 12, 2022
@sricharanvuppu
Copy link
Member

Published to local Maven using ./gradlew publishToMavenLocal after build

when used groupId="x.y.z" it is not reflected in .m2 folder (maven local) but when used group="x.y.x" it is reflected in .m2 folder (maven local)

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Oct 14, 2022

Hey @sricharanvuppu it should be groupId the publish will happen when executed ./build.sh manifests/2.4.0/opensearch-2.4.0.yml --component cross-cluster-replication to the folder tar/builds/opensearch/maven/org/opensearch/plugin/, Example geospatial with latest CI pass for 2.4.0.
@ankitkala @bbarani @peterzhuamazon

@ankitkala ankitkala enabled auto-merge (squash) October 14, 2022 12:17
@ankitkala ankitkala disabled auto-merge October 14, 2022 12:18
@ankitkala ankitkala enabled auto-merge (squash) October 14, 2022 12:19
@sricharanvuppu sricharanvuppu self-requested a review October 14, 2022 12:31
@sricharanvuppu sricharanvuppu merged commit 5882c09 into opensearch-project:main Oct 14, 2022
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-589-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5882c09221306c5eff140fc29939a0d2395d4b25
# Push it to GitHub
git push --set-upstream origin backport/backport-589-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-589-to-2.x.

@peterzhuamazon
Copy link
Member

@sricharanvuppu @prudhvigodithi can this be ported to 2.x please?

ankitkala pushed a commit that referenced this pull request Oct 19, 2022
add groupId = org.opensearch.plugin

(cherry picked from commit 5882c09)
ankitkala pushed a commit that referenced this pull request Oct 19, 2022
add groupId = org.opensearch.plugin

(cherry picked from commit 5882c09)
ankitkala pushed a commit that referenced this pull request Oct 19, 2022
add groupId = org.opensearch.plugin

(cherry picked from commit 5882c09)
Signed-off-by: Ankit Kala <ankikala@amazon.com>
@ankitkala
Copy link
Member

@sricharanvuppu @prudhvigodithi can this be ported to 2.x please?

Backport pr for 2.x: #593

ankitkala added a commit that referenced this pull request Oct 21, 2022
add groupId = org.opensearch.plugin

(cherry picked from commit 5882c09)
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Co-authored-by: sricharanvuppu <113983630+sricharanvuppu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants