-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spotless for formatting Java source files #120
Conversation
- add spotlessJavaCheck. - format existing code. - upgrade deprecated gradle constructs. Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
@mulugetam we probably need to exclude some binary files (as GA checks fail), thank you. |
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
@reta Looks to me that |
Oh I see, thanks @mulugetam , I just briefly looked into failure I thought there are some attempts to format binary files, non issue |
1) Remove the Elasticsearch attribution in spotless formatter. 2) Use java instead of 'java'. 3) Remove version resolution for jackson. Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
@reta Fixed. Please review. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/custom-codecs/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/custom-codecs/backport-2.x
# Create a new branch
git switch --create backport/backport-120-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 27e925c183f4c2f5c550204e2eedd2caab7b9811
# Push it to GitHub
git push --set-upstream origin backport/backport-120-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/custom-codecs/backport-2.x Then, create a pull request where the |
@mulugetam could you please apply backport to |
Description
./gradlew spotlessJavaCheck
).plugins.withId('java')
.Issues Resolved
Resolves inconsistent code formatting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.