Remove redundant array resizing in Zstd compression modes. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com>
mulugetam
requested review from
andrross,
reta,
nknize and
sarthakaggarwal97
as code owners
reta
reviewed
Mar 15, 2024
| @@ -188,7 +188,6 @@ public void decompress(DataInput in, int originalLength, int offset, int length, | |||
|
|
|||
| // Read blocks that intersect with the interval we need | |||
| while (offsetInBlock < offset + length) { | |||
| bytes.bytes = ArrayUtil.grow(bytes.bytes, bytes.length + blockLength); | |||
reta
reviewed
Mar 15, 2024
| @@ -148,7 +148,6 @@ public void decompress(DataInput in, int originalLength, int offset, int length, | |||
|
|
|||
| // Read blocks that intersect with the interval we need | |||
| while (offsetInBlock < offset + length) { | |||
| bytes.bytes = ArrayUtil.grow(bytes.bytes, bytes.length + blockLength); | |||
reta
reviewed
Mar 15, 2024
|
|
||
| final int uncompressed = (int) Zstd.decompressByteArray(output, 0, l, compressed, 0, compressedLength); | ||
| System.arraycopy(output, 0, bytes.bytes, bytes.length, uncompressed); | ||
| final int uncompressed = (int) Zstd.decompressByteArray(bytes.bytes, bytes.length, l, compressed, 0, compressedLength); |
reta
approved these changes
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Mulugeta Mammo <mulugeta.mammo@intel.com> (cherry picked from commit be53471) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes redundant array resizes in Zstd compression modes.
Issues Resolved
Improves performance by eliminating redundant array resizing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.