[2.x] Lucene 9.9.1 Upgrade #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
requested review from
andrross,
reta and
nknize
as code owners
|
@reta thoughts on this? I've added to bwc test to validate flow between 2.11 and 2.x branch. Please take a look. |
sarthakaggarwal97
force-pushed
the
lucene-upgrade-first-2.x
branch
from
8c08576
to
e599943
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
lucene-upgrade-first-2.x
branch
from
e599943
to
d9e4ce8
Compare
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
bwc-test/src/test/java/org/opensearch/customcodecs/bwc/CustomCodecsBwcCompatibilityIT.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jan 26, 2024
src/main/java/org/opensearch/index/codec/customcodecs/Lucene99CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jan 26, 2024
src/main/java/org/opensearch/index/codec/customcodecs/backward_codecs/Lucene95CustomCodec.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
reta
reviewed
Jan 26, 2024
sarthakaggarwal97
force-pushed
the
lucene-upgrade-first-2.x
branch
4 times, most recently
from
1ff0d98
to
08dfad7
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
lucene-upgrade-first-2.x
branch
from
08dfad7
to
463bfce
Compare
reta
reviewed
Jan 26, 2024
src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomStoredFieldsFormat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
lucene-upgrade-first-2.x
branch
from
a04ea25
to
fc04ea8
Compare
reta
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks great (to me), thanks @sarthakaggarwal97 ! @msfroh could you please double check? Thank you!
andrross
approved these changes
Jan 26, 2024
msfroh
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change would upgrade the underlying Lucene95 codec of the custom codecs to Lucene99 codec for
2.xIn line with the community discussion over here #95, we are proceeding with the merge of
2.xfirst, and would carry on with the port to main.Issues Resolved
#94
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.