feat: add form experiment badge #13

wanglam · 2023-11-24T08:16:30Z

Description

Separate ChatWindowHeaderTitle
Add experimental badge

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…com/jestjs/jest/issues/6229\#issuecomment-403539460 Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

…(#10) * feat: change implementation of basic_input_output to built-in parser Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable build input-output message Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: sort interactions Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use parent_interaction_id as traceId Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

raintygao · 2023-11-24T09:20:34Z

public/components/chat_experimental_badge.tsx

+  const closePopover = useCallback(() => {
+    setVisible(false);
+  }, []);
+
+  const handleIconClick = useCallback((e) => {
+    setVisible((flag) => !flag);
+  }, []);


Lint seems to throw a warning or error. Prefer add setVisible to dependencies or not use useCallback to wrap.

i don't think setVisible is needed in dependencies, it's always the same. if needed you can add comment to ignore the linter warning, and in the future we can probably use something like useEffectEvent. But i agree the useCallback doesn't seem to do much here

raintygao · 2023-11-24T09:26:44Z

public/components/chat_window_header_title.tsx

+      if (status === 'updated') {
+        chatContext.setTitle(newTitle);
+      }
+      setRenameModelOpen(false);


Same as above.

* feat: add mechannism to register messageParser Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add interaction into message_bubble.tsx Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: lint checker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

SuZhou-Joe · 2023-11-27T10:27:02Z

Would you mind adding this PR into CHANGELOG.md? It is an official and complete feature.

joshuali925 · 2023-11-27T19:13:08Z

public/components/chat_experimental_badge.tsx

+export const ChatExperimentalBadge = ({ onClick }: ChatExperimentalBadgeProps) => {
+  const [visible, setVisible] = useState(false);
+
+  const closePopover = useCallback(() => {


why useCallback? i don't think EuiPopover is memorized

joshuali925 · 2023-11-27T19:17:50Z

public/components/chat_window_header_title.tsx

+      New conversation
+    </EuiContextMenuItem>,
+    <EuiContextMenuItem
+      key="save-as-notebook"


not this PR but maybe TODO for future: would be better if this functionality comes from observability so that olly doesn't show the button if notebooks is not installed, and olly doesn't need to track breaking changes from observability

Good point. Will add some annotations about it.

joshuali925 · 2023-11-27T19:18:53Z

public/components/chat_window_header_title.tsx

+        closePopover();
+      }}
+      // User only can save conversation when he send a message at least.
+      disabled={chatState.messages.filter((item) => item.type === 'input').length < 1}


nit

Suggested change

disabled={chatState.messages.filter((item) => item.type === 'input').length < 1}

disabled={chatState.messages.every((item) => item.type !== 'input')}

joshuali925 · 2023-11-27T19:21:46Z

public/components/chat_window_header_title.tsx

+      </EuiPopover>
+      {isRenameModelOpen && (
+        <EditConversationNameModal
+          sessionId={chatContext.sessionId!}


modal should be in the same react context, why does it need to be passed in?

The EditConversationNameModal is a shared component, it will be reused in public/tabs/history/chat_history_search_list.tsx. We need to pass different sessionId and defaultTitle here. So it doesn't use the sessionId from the chat context.

* Integrate Memeory APIs of agent framework Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add TODO to getSessions() Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com>

ruanyl · 2023-11-28T03:50:48Z

public/components/chat_window_header_title.tsx

+  const { loadChat } = useChatActions();
+  const core = useCore();
+  const [isPopoverOpen, setPopoverOpen] = useState(false);
+  const [isRenameModelOpen, setRenameModelOpen] = useState(false);


Seems this was added earlier, but it's a typo: model -> modal

* feat: add implement visualization in customized parser Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add csv-parser lib Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add csv-parser lib Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

Signed-off-by: Lin Wang <wonglam@amazon.com>

SuZhou-Joe added 24 commits November 23, 2023 10:50

feat: add workflows

1364065

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless workflow

d616e09

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: fix unit test flow

16ae642

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make workflow run

6d26618

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make workflows run

f12a316

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make workflows run

af89436

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: make windows flow pass

1821b6c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: change .babelrc to babel.config.js according to https://github.…

50bfccd

…com/jestjs/jest/issues/6229\#issuecomment-403539460 Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use agent framework API to generate answer

267131c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: comply with multi type of agent

04ef332

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: integrate with memory APIs

7cfd027

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: use the agent id from request body

20f2092

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: remove useless code

60b3a7c

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: update babel.config.ts

7d4153b

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: modify API path according to doc

8daadfc

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add mechannism to register messageParser

b20f382

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: sort when run

2ca5ced

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: sort when run

d0ddf09

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add doc change

f46739b

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add diagram

8d54ff0

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: optimize code

b191faa

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: add error handling

4bcca2a

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

feat: optimize

b7035bd

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

wanglam marked this pull request as ready for review November 24, 2023 08:24

wanglam requested review from joshuali925 and anirudha as code owners November 24, 2023 08:24

raintygao approved these changes Nov 24, 2023

View reviewed changes

joshuali925 approved these changes Nov 27, 2023

View reviewed changes

Integrate Memeory APIs of agent framework (#15)

979404d

* Integrate Memeory APIs of agent framework Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add TODO to getSessions() Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com>

ruanyl reviewed Nov 28, 2023

View reviewed changes

ruanyl approved these changes Nov 29, 2023

View reviewed changes

SuZhou-Joe added backport langchain and removed backport langchain labels Nov 29, 2023

wanglam mentioned this pull request Nov 29, 2023

Feat add experiment icon and tooltip langchain #21

Merged

wanglam added 6 commits November 30, 2023 11:08

feat: add form experiment badge

90dd96f

Signed-off-by: Lin Wang <wonglam@amazon.com>

refactor: replace filter length with every

b952b35

Signed-off-by: Lin Wang <wonglam@amazon.com>

refactor: remove unnecessary useCallback

f953a17

Signed-off-by: Lin Wang <wonglam@amazon.com>

docs: add changelog for add experimental badge

50c2d91

Signed-off-by: Lin Wang <wonglam@amazon.com>

refactor: renameModelOpen to renameModalOpen

e4017f8

Signed-off-by: Lin Wang <wonglam@amazon.com>

feat: update link and margin

3e1505f

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam force-pushed the feat-add-experiment-icon-and-tooltip branch from 9895949 to 3e1505f Compare November 30, 2023 03:10

SuZhou-Joe closed this Dec 1, 2023

SuZhou-Joe reopened this Dec 1, 2023

SuZhou-Joe closed this Dec 1, 2023

SuZhou-Joe reopened this Dec 1, 2023

SuZhou-Joe closed this Dec 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add form experiment badge #13

feat: add form experiment badge #13

wanglam commented Nov 24, 2023

raintygao Nov 24, 2023

joshuali925 Nov 27, 2023

raintygao Nov 24, 2023 •

edited

Loading

SuZhou-Joe commented Nov 27, 2023

joshuali925 Nov 27, 2023

joshuali925 Nov 27, 2023

wanglam Nov 28, 2023

joshuali925 Nov 27, 2023

joshuali925 Nov 27, 2023

wanglam Nov 28, 2023

ruanyl Nov 28, 2023

	disabled={chatState.messages.filter((item) => item.type === 'input').length < 1}
	disabled={chatState.messages.every((item) => item.type !== 'input')}

feat: add form experiment badge #13

feat: add form experiment badge #13

Conversation

wanglam commented Nov 24, 2023

Description

Issues Resolved

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raintygao Nov 24, 2023 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe commented Nov 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raintygao Nov 24, 2023 •

edited

Loading