Integrate Memeory APIs of agent framework #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe
approved these changes
Nov 27, 2023
wanglam
reviewed
Nov 27, 2023
| title: item._source.name, | ||
| version: 1, | ||
| createdTimeMs: Date.parse(item._source.create_time), | ||
| updatedTimeMs: Date.parse(item._source.create_time), |
There was a problem hiding this comment.
Is there any update time in the source data? I think we should use update time here.
There was a problem hiding this comment.
The backend API doesn't return update_time by now, it hasn't been implemented, I will update the code once it's ready.
There was a problem hiding this comment.
Maybe we can add some todo about it.
There was a problem hiding this comment.
Have done that, thanks!
Signed-off-by: gaobinlong <gbinlong@amazon.com>
wanglam
approved these changes
Nov 27, 2023
SuZhou-Joe
approved these changes
Nov 27, 2023
raintygao
approved these changes
Nov 28, 2023
SuZhou-Joe
merged commit 979404d
into
opensearch-project:feature/agent-framework
7 checks passed
SuZhou-Joe
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Integrate Memeory APIs of agent framework Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add TODO to getSessions() Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Integrate Memeory APIs of agent framework Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add TODO to getSessions() Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate memory APIs of the agent framework in ml-commons plugin, such as:
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.