[Incontext insights] clean up components and usability #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
17 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 90.02% 90.92% +0.90%
==========================================
Files 54 61 +7
Lines 1433 1443 +10
Branches 347 347
==========================================
+ Hits 1290 1312 +22
+ Misses 141 129 -12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Hi @kavilla , is it needed for 2.13? |
|
@kavilla would you mind rebase this PR with main to resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some of the comments on the original PR for this component, with changes from user studies.
Added a UI Settings which can be modified in Advanced Settings and increase the timeout as one of the issues is that the original was too fast to see the initial state on load. Then I felt it was really long so made it configurable for users to decide whats best and for us to fine tune it with more insight.
Does not resolve every issue but I still plan on making it so a custom attribute that gets stylized instead of making plugins wrap components. But higher priorities have made me delay these changes. So opening to not let it get too stale.
Issues Partially Resolved
#143
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.