Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added an AI assistant trigger button to query editor #265

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Aug 30, 2024

Description

Add AI assistant trigger to query editor

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@@ -99,6 +101,9 @@ export class AssistantPlugin
return account;
};

// setup ui trigger
bootstrap(setupDeps.uiActions);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems uiActions is missing in the opensearch_dashboard.json file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, missed to commit that file, fixed now

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl merged commit 9d81044 into opensearch-project:main Sep 6, 2024
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9d81044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.17
# Create a new branch
git switch --create backport/backport-265-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d81044340685710afb9ffea9e9ca207c3fcbc48
# Push it to GitHub
git push --set-upstream origin backport/backport-265-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-265-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.17
# Create a new branch
git switch --create backport/backport-265-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d81044340685710afb9ffea9e9ca207c3fcbc48
# Push it to GitHub
git push --set-upstream origin backport/backport-265-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-265-to-2.17.

gaobinlong pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9d81044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9d81044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6cce85d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 6, 2024
…) (#280)

(cherry picked from commit 9d81044)


# Conflicts:
#	CHANGELOG.md


(cherry picked from commit 6cce85d)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants