Refactor: refactor contextProvider get to reduce re-fetch #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <tygao@amazon.com>
wanglam
reviewed
Oct 29, 2024
| const context = await incontextInsight.contextProvider?.(); | ||
| const monitorType = context?.additionalInfo?.monitorType; | ||
| const dsl = context?.additionalInfo?.dsl; | ||
| if (!contextObject) return; |
There was a problem hiding this comment.
Nit: The contextObject was initialized in onGenerateSummary below and was only executed once. The displayDiscoverButton won't be true if contextObject is undefined. I'm not sure if it matches the business logic.
wanglam
approved these changes
Oct 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* refactor: refacotr contextProvider get to reduce re-fetch Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 5ac419e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* refactor: refacotr contextProvider get to reduce re-fetch Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 5ac419e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Oct 29, 2024
* refactor: refacotr contextProvider get to reduce re-fetch Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 5ac419e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
raintygao
pushed a commit
that referenced
this pull request
Oct 29, 2024
* refactor: refacotr contextProvider get to reduce re-fetch Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 5ac419e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
raintygao
added a commit
to raintygao/dashboards-assistant
that referenced
this pull request
Jan 22, 2025
…-project#365) * refactor: refacotr contextProvider get to reduce re-fetch Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor contextProvider get to reduce re-fetch
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.