Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only support visual editor alerts to navigate to discover #368

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

raintygao
Copy link
Collaborator

Description

only support visual editor alerts to navigate to discover

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: tygao <tygao@amazon.com>
@raintygao raintygao added backport 2.x Trigger the backport flow to 2.x backport 2.18 labels Oct 30, 2024
@ruanyl
Copy link
Member

ruanyl commented Oct 30, 2024

should this backport to 2.18?

@raintygao
Copy link
Collaborator Author

should this backport to 2.18?

Yes, we may could catch this 2.18 release.

@raintygao raintygao merged commit 50fef5c into opensearch-project:main Oct 30, 2024
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
* feat: only support visual editor alerts to navigate to discover

Signed-off-by: tygao <tygao@amazon.com>

* doc: add changelog

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit 50fef5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
* feat: only support visual editor alerts to navigate to discover

Signed-off-by: tygao <tygao@amazon.com>

* doc: add changelog

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit 50fef5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
raintygao pushed a commit that referenced this pull request Oct 30, 2024
#369)

* feat: only support visual editor alerts to navigate to discover

Signed-off-by: tygao <tygao@amazon.com>

* doc: add changelog

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit 50fef5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
raintygao pushed a commit that referenced this pull request Oct 30, 2024
#370)

* feat: only support visual editor alerts to navigate to discover

Signed-off-by: tygao <tygao@amazon.com>

* doc: add changelog

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit 50fef5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
raintygao added a commit to raintygao/dashboards-assistant that referenced this pull request Nov 11, 2024
raintygao added a commit to raintygao/dashboards-assistant that referenced this pull request Nov 11, 2024
ruanyl pushed a commit that referenced this pull request Nov 11, 2024
…er (#368) (#370)" (#371)

This reverts commit 2ba4853.

Signed-off-by: tygao <tygao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants