Add unit test for useFetchAgentFrameworkTraces Hook #77
Conversation
Hailong-am
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
wanglam and
raintygao
as code owners
Hailong-am
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 75.39% 83.52% +8.13%
==========================================
Files 43 43
Lines 1024 1026 +2
Branches 238 239 +1
==========================================
+ Hits 772 857 +85
+ Misses 251 168 -83
Partials 1 1 ☔ View full report in Codecov by Sentry. |
| @@ -33,7 +33,7 @@ export const useFetchAgentFrameworkTraces = (traceId: string) => { | |||
| .catch((error) => dispatch({ type: 'failure', error })); | |||
|
|
|||
| return () => abortController.abort(); | |||
There was a problem hiding this comment.
Shall we add one test case for assert this abort method has been called after unmount.
There was a problem hiding this comment.
sure, case added.
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
| }) | ||
| ); | ||
|
|
||
| waitFor(() => { |
There was a problem hiding this comment.
This line seems problematic, if I put await waitFor, the test will failed, and also I see a console error on this test
There was a problem hiding this comment.
Add a condition check for unmount to remediate console log error about [Can't perform a React state update on an unmounted component]
.catch((error) => {
if (error.name === 'AbortError') return;
dispatch({ type: 'failure', error });
});Signed-off-by: Hailong Cui <ihailong@amazon.com>
Description
Add unit test for useFetchAgentFrameworkTraces
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.