-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support create / provision / deprovision from editor page #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to include size 1000 Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
…kflow state API Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
April 4, 2024 23:04
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 22.18% 21.86% -0.32%
==========================================
Files 57 57
Lines 870 974 +104
Branches 92 106 +14
==========================================
+ Hits 193 213 +20
- Misses 673 757 +84
Partials 4 4 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Apr 4, 2024
joshpalis
approved these changes
Apr 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 37bbbfa)
ohltyler
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the creation, and adds provision & deprovision functionality on the editor page with new buttons. Note these buttons are placeholders and nothing is finalized regarding where they will live or the exact flow. But this proves out the capability.
More details:
provision
/deprovision
APIs and integrates with redux storeget state
API and integrates with redux storeprovision
option fromcreate
API to simplify state managementvalidateFormAndFlow()
helper fn. Currently only used in save flow, but will likely be used in other places for adhoc provisioning/deprovisioning and realtime validation is needed.Misc fixes
size: 10
=>size: 1000
useDispatch()
touseAppDispatch()
, which is a more specific dispatch that's hooked up to our specific redux store / middleware with determined return types, which are async thunks. see here for details: https://redux-toolkit.js.org/usage/usage-with-typescript#getting-the-dispatch-typeDemo video:
lifecycle.flows.webm
Issues Resolved
Makes progress on #75
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.