Add initial logic to generate ReactFlow workspace #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added
backport 2.x
rapid
refactor
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
changed the title
joshpalis
approved these changes
May 18, 2024
dbwiddis
approved these changes
May 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 73930ab)
ohltyler
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up the basic conversion logic to generate the ReactFlow workspace's nodes/edges based on a WorkflowConfig. As an example, given a config with ingest processors defined under
ingest.enrich, UI will generate a Transformer component and connect it between the initial request, and the index, to visualize the data flow. Example in screenshot below.More specifics:
Workflowto be dynamically generated based on theconfig, instead of using the persistedworkspace_flow. (we may deprecateworkspace_flowas we may not need to persist that for now, until we want drag-and-drop support)uiConfigToWorkspaceFlowand all of its sub/helper fns. Some are implemented and some are stubbed, will be filled out as the config details and fields we want to support are finalized. At a high level, we will have a few static/consistent workspace components for all workflows, such as an 'index' component under both 'Ingest' and 'Search' flows. As users add processors under ingest/search pipelines, we will dynamically add components and link them up in the workspace.Screenshot:
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.