Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query execution; support index settings/mappings; support create/edit states for ingest #186

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 19, 2024

Description

This PR achieves various functionalities. The 3 main pieces are:

  1. Supporting query execution and seeing results in the Tools panel on the search-inputs side
  2. Supporting/exposing index mappings and settings to set on the ingest-inputs side
  3. Support different states on the ingest-inputs side.

More details:

  • adds query state in WorkflowInputs similar to ingest state. When populated, shows the query results in the Tools component
  • implements the query results tab in the Tools component to show the results, similar to ingest response
  • adds a check and different states on the ingest-inputs side, depending on if ingest has been ran yet. Add a few things indicating in "edit" state, such as buttons and their functionalities changing
  • adds index mappings and index settings as fields in the WorkflowConfig
  • integrates JSON strings as a form input type, including default values, schema/validation, formik integration, and auto-formatting on blur. Utilized for the added index mappings and index settings form inputs.
  • integrates the ingest docs into the form for consistent validation / editing experience. Note we don't include in the config itself as we don't want to index this alongside the rest of the workflow configuration.

Demo video, showing the form integration of ingest docs, index settings, and index mappings, running ingest, showing the edit ingest state, and then executing a query, and the auto-switch of the tools tab to show the query response

screen-capture.38.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ohltyler added 6 commits June 18, 2024 09:57
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
…; add advanced settings with json fields

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler marked this pull request as ready for review June 19, 2024 18:23
@ohltyler ohltyler merged commit d6a1805 into opensearch-project:main Jun 19, 2024
6 checks passed
@ohltyler ohltyler deleted the updates-2 branch June 19, 2024 18:27
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
…ate/edit states for ingest (#186)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit d6a1805)
ohltyler added a commit that referenced this pull request Jun 19, 2024
…ate/edit states for ingest (#186) (#187)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit d6a1805)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants