Add initial server route; add core & route services #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
jackiehanyang
approved these changes
Sep 11, 2023
dbwiddis
approved these changes
Sep 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 9991af8)
ohltyler
added a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up more of the server-side infrastructure, and adds an initial OpenSearch route to search an index. This also sets up the client-side APIs to the server, and sets up a
RouteServicewhich can be used in components. This service is bootstrapped in the plugin'ssetup()lifecycle and exposed as a service to be used in downstream React components.This PR also removes the
CoreServicesContextapproach to expose core services; instead, we setCoreStartas an exposed service just likeRouteService, and then fetch any core services when needed viagetCore()call. This follows the strategy used by existing core OSD plugins, and is a clean way to determine the required plugin dependencies and a consistent way to access them.Testing:
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.