Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch workflow state; align data models with backend #88

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fetch workflow state; align data models with backend #88

merged 1 commit into from
Feb 29, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Feb 29, 2024 •
edited
Loading

Description

This PR improves the detector list in a few ways:

  1. Onboards the Search Workflow State API to the client to fetch corresponding state for workflows. Included in a new helper fn to combine the results into a single Workflow map/dictionary to return to client-side. TODOs added w/ PR links that can simplify the frontend logic in the future
  2. Updates some of the Workflow and WORKFLOW_STATE data models to align with the backend
  3. Updates UI components (column config, table filter) to align with the latest mocks, including updated fields and display accordingly

Note: last updated / last launched are placeholders until opensearch-project/flow-framework#548 is completed.

Updated page:

Screenshot 2024-02-29 at 10 30 00 AM

Issues Resolved

Makes progress on #65, #70. Leaving open until delete functionality is added.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Fetch workflow state; align data models with backend
0d1353d 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler merged commit 96e2f1a into opensearch-project:main Feb 29, 2024
8 of 9 checks passed
@ohltyler ohltyler deleted the workflow-model branch February 29, 2024 19:01
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 29, 2024
@ohltyler @github-actions
Fetch workflow state; align data models with backend (#88)
ccf0a59 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 96e2f1a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 29, 2024
Merged
ohltyler added a commit that referenced this pull request Feb 29, 2024
@opensearch-trigger-bot @ohltyler
Fetch workflow state; align data models with backend (#88) (#89)
dadbc78 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 96e2f1a)

Co-authored-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request rapid workflow list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohltyler @dbwiddis