Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add layer and panel part of cluster layer #408

Closed

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented May 4, 2023

Description

cluster layer -> add layer and layer setting panel part

Use OpenSearch 3.0 version and this OSD code opensearch-project/OpenSearch-Dashboards#3974 env.

Issues Resolved

#250

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: tygao <tygao@amazon.com>
@raintygao raintygao requested a review from a team May 4, 2023 08:27
Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #408 (e671ebd) into main (ce8d829) will decrease coverage by 1.58%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   41.36%   39.78%   -1.58%     
==========================================
  Files          53       62       +9     
  Lines        1777     1973     +196     
  Branches      327      358      +31     
==========================================
+ Hits          735      785      +50     
- Misses       1014     1160     +146     
  Partials       28       28              

see 18 files with indirect coverage changes

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@VijayanB
Copy link
Member

VijayanB commented May 4, 2023

Please create a feature branch and raise PR to that branch. Will merge to main once we are close to feature complete.

@raintygao
Copy link
Contributor Author

raintygao commented May 5, 2023

Set this PR frozen for now due to ui changes and tech solution changes.

@raintygao raintygao closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants