Allow filtering geo_shape fields around map extent #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 41.36% 41.40% +0.04%
==========================================
Files 53 53
Lines 1777 1775 -2
Branches 327 326 -1
==========================================
Hits 735 735
+ Misses 1014 1012 -2
Partials 28 28 |
From 2.9, geoshape supports geo bounding box. Hence, remove the constraint that disables geo bounding box for non geopoint fields. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
remove-constraint
branch
from
c25e2d6 to
8f629f0
Compare
|
@VijayanB Could you please provide the demo video that verify the feature? |
junqiu-lei
approved these changes
Aug 4, 2023
I don't think they are related. |
naveentatikonda
approved these changes
Aug 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 6, 2023
From 2.9, geoshape supports geo bounding box. Hence, remove the constraint that disables geo bounding box for non geopoint fields. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit a4e92a0)
VijayanB
pushed a commit
that referenced
this pull request
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From 2.9, geoshape supports geo bounding box. Hence, remove the constraint that disables geo bounding box for non geopoint fields.
Screen.Recording.2023-08-04_480.mov
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.