Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove static integrations from codebase #1391

Closed
Swiddis opened this issue Jan 30, 2024 · 1 comment
Closed

[FEATURE] Remove static integrations from codebase #1391

Swiddis opened this issue Jan 30, 2024 · 1 comment
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project wontfix This will not be worked on

Comments

@Swiddis
Copy link
Collaborator

Swiddis commented Jan 30, 2024

Is your feature request related to a problem?
Since dynamic catalogs is implemented, we want to remove the built-in integrations and bundle them separately.

What solution would you like?
There are a few solutions for this:

  • Remove existing integrations from the codebase
  • Fix the tests that rely on this directory (likely will keep a couple copies of integrations around as test data)
  • Add handling for the empty integration state on the frontend
  • Add a loading screen for when fetching integrations (required due to [FEATURE] Faster loading of dynamic integrations #1389)

What alternatives have you considered?
We can keep the existing content as a default bundle, which eliminates the need for refactoring tests or adding an empty state, but introduces more maintenance overhead for the built-in integrations.

Do you have any additional context?
Dynamic Catalogs #1253
@Swiddis Swiddis added enhancement New feature or request untriaged integrations Used to denote items related to the Integrations project v2.12.0 and removed untriaged labels Jan 30, 2024
@Swiddis Swiddis mentioned this issue Jan 31, 2024
Closed
@Swiddis Swiddis added wontfix This will not be worked on and removed v2.12.0 labels Feb 2, 2024
@Swiddis
Copy link
Collaborator Author

Swiddis commented Feb 5, 2024

Not planned to remove them outright, will mix them with build process instead. Closing as not planned.

@Swiddis Swiddis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this issue Apr 18, 2024
@opensearch-trigger-bot
No blank backend role before adding a new one in Create User page (op…
edaf637 
…ensearch-project#1384) (opensearch-project#1391)

* Add last backend role empty check

Signed-off-by: nursaadat <SNursultan@dar.kz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Swiddis