Metrics Explorer - single-line graph only, no legends #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
pjfitzgibbons
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
kavithacm
reviewed
Oct 4, 2023
| @@ -399,7 +396,7 @@ export const renderCatalogVisualization = async ({ | |||
| layoutConfig: { | |||
| height: 390, | |||
| margin: { t: 5 }, | |||
| legend: { orientation: 'h', yanchor: 'top', x: 0.0, y: -0.4 }, | |||
| legend: { visible: false }, | |||
There was a problem hiding this comment.
why is the legend being removed here?
There was a problem hiding this comment.
Making a call for 2.11 to remove multi-line. The resulting legend is a single entry of {}, which is not helpful.
So, just removing it.
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
========================================
Coverage 44.38% 44.38%
========================================
Files 322 325 +3
Lines 19239 19544 +305
Branches 4604 4659 +55
========================================
+ Hits 8539 8675 +136
- Misses 10656 10825 +169
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
YANG-DB
reviewed
Oct 4, 2023
| attributesGroupBy.length === 0 | ||
| ? catalogTableName | ||
| : `${aggregation} by(${attributesGroupString}) (${catalogTableName})`; | ||
| // const promQuery = |
There was a problem hiding this comment.
it the comment needed for future enhancements ?
YANG-DB
approved these changes
Oct 4, 2023
Swiddis
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Metrics Explorer - single-line graph only, no legends --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit 408d38f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pjfitzgibbons
added a commit
that referenced
this pull request
Oct 5, 2023
* Metrics Explorer - single-line graph only, no legends --------- (cherry picked from commit 408d38f) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Metrics Explorer - single-line graph only, no legends --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit 408d38f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 15, 2023
…ject#1068) * Metrics Explorer - single-line graph only, no legends --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ject#1068) (opensearch-project#1073) * Metrics Explorer - single-line graph only, no legends --------- (cherry picked from commit 408d38f) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit fe565f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify Metric Explorer to display single-line graphs only, no legends
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.