Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Backport 2.x][Feature] Support SQL direct query in Observabi… #1075

Closed
wants to merge 1 commit into from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 5, 2023

…lity (#988) (#1072)"

This reverts commit cefd57f.

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1075 (7b674e4) into 2.x (ed572dc) will not change coverage.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #1075   +/-   ##
=======================================
  Coverage   43.55%   43.55%           
=======================================
  Files         313      313           
  Lines       18708    18708           
  Branches     4517     4517           
=======================================
  Hits         8149     8149           
  Misses      10517    10517           
  Partials       42       42           
Flag Coverage Δ
dashboards-observability 43.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@derek-ho derek-ho closed this Oct 5, 2023
pjfitzgibbons pushed a commit that referenced this pull request Oct 5, 2023
* Fixed [BUG]: Visualization height panel issue for all charts

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Updated snapshots

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted snapshots

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted no_results.test.tsx.snap

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted no_results.test.tsx.snap

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants