[Backport 2.11] Add callout and modify content for S3 datasource #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add callout and modify content for S3 datasource Signed-off-by: Derek Ho <dxho@amazon.com> * Update s3 documentation Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 1a73071) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
derek-ho
approved these changes
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.11 #1113 +/- ##
=======================================
Coverage 44.23% 44.23%
=======================================
Files 327 327
Lines 19478 19479 +1
Branches 4643 4643
=======================================
+ Hits 8616 8617 +1
Misses 10817 10817
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 11, 2023
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 30, 2023
* Fixed threshold crashes and color theme not applying on bar, line, scatter and histogram Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * bugs fixed testing: in progress Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> * testing + fixing done Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> * bar crash fixed Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> * histogrm color theme options fixed Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> * log removed Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com> Co-authored-by: ruchika-narang <ruchika_narang@persistent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1a73071 from #1111.