Add integrations queries for Flint #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 44.01% 44.01% -0.01%
==========================================
Files 328 328
Lines 19612 19644 +32
Branches 4733 4730 -3
==========================================
+ Hits 8632 8646 +14
- Misses 10406 10421 +15
- Partials 574 577 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq and
mengweieric
as code owners
Swiddis
requested review from
vamsi-amazon,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
YANG-DB
approved these changes
Oct 27, 2023
derek-ho
reviewed
Oct 27, 2023
| title: 'Table', | ||
| lower: 'table', | ||
| help: 'Select a table to pull the data from.', | ||
| title: 'Catalog', |
There was a problem hiding this comment.
Because the form isn't referring to a table, I asked around for a better name.
derek-ho
reviewed
Oct 27, 2023
| @@ -185,6 +188,7 @@ export function SetupIntegrationForm({ | |||
| [] as Array<{ label: string }> | |||
| ); | |||
| const [isSuggestionsLoading, setIsSuggestionsLoading] = useState(true); | |||
| const [isBlurred, setIsBlurred] = useState(false); | |||
There was a problem hiding this comment.
there is also onBlur function that comes along with most elements that you can use and avoid this separate re-implementation
There was a problem hiding this comment.
Where is it documented? I'd heard about it but didn't find any references.
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
derek-ho
approved these changes
Oct 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 22b6fc6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 22b6fc6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For making integrations work with Flint, we need to provide a set of queries that can be used to create OpenSearch indices for querying. The PR is still in the draft phase as we compile our queries and work towards testing them in real scenarios, and adding unit tests + documentation for the functionality.
Todo:
Nginx Table QueriesGet VPC Flow queries from @YANG-DBGet Cloudtrail queries from @YANG-DB (available in update the cloudtrail s3 integration assets opensearch-catalog#81)Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.