[Backport 2.x] Fix integration labeling to identify S3 integrations #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Switch from toast to callout for set up failures Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix label selection for truncated labels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix button color Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove loading progress bar Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor labels to make distinctions more semantically useful Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 562c3e0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Swiddis
approved these changes
Oct 24, 2023
mengweieric
approved these changes
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1165 +/- ##
==========================================
- Coverage 44.24% 44.24% -0.01%
==========================================
Files 329 329
Lines 19534 19542 +8
Branches 4718 4723 +5
==========================================
+ Hits 8643 8646 +3
- Misses 10324 10328 +4
- Partials 567 568 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ect#1157) (opensearch-project#1165) * Switch from toast to callout for set up failures * Fix label selection for truncated labels * Fix button color * Fix tests * Remove loading progress bar * Remove unused imports * Refactor labels to make distinctions more semantically useful --------- (cherry picked from commit 562c3e0) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 5beb92c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 562c3e0 from #1157.