improve lint workflow to avoid fast fail #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
6 tasks
mengweieric
approved these changes
Jan 22, 2024
| jq -r '.[]' ${HOME}/files_modified.json ${HOME}/files_added.json | sort | uniq > /tmp/changed_files.txt | ||
| CHANGED_FILES=$(cat /tmp/changed_files.txt) | ||
| echo "These are the changed files: $CHANGED_FILES" | ||
| CHANGED_FILES=($(jq -r '.[]' ${HOME}/files_modified.json ${HOME}/files_added.json | grep '.\+.\(js\|ts\|tsx\)$' | sort -u)) |
There was a problem hiding this comment.
I remember one of the issues we were trying to tackle was when a file is renamed, both 'modified' and 'added' shas will show the same renamed file which lead to later lint that file more than once, is it? @RyanL1997 , is this considered in the new change as I saw uniq was removed?
There was a problem hiding this comment.
prefer sort -u over sort | uniq. they have the same output
There was a problem hiding this comment.
@mengweieric Yes, that shouldn't be a problem. Since the above step Check Changes of Files has filtered the output
RyanL1997
approved these changes
Jan 23, 2024
Swiddis
approved these changes
Jan 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit e3116ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/dashboards-observability
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
mengweieric
pushed a commit
that referenced
this pull request
Jan 30, 2024
(cherry picked from commit e3116ca) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
to paulstn/dashboards-observability
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…pensearch-project#1384) (cherry picked from commit e3116ca) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 305e037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make it fail after linting all files
Issues Resolved
#1369 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.