(query assist) hide dot indices #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
YANG-DB
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1413 +/- ##
=======================================
Coverage 54.26% 54.27%
=======================================
Files 315 315
Lines 11165 11167 +2
Branches 2990 2991 +1
=======================================
+ Hits 6059 6061 +2
Misses 5057 5057
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7442e6f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit 7442e6f) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7442e6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not display hidden indices in query assist index selector
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.