-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade plotly to v2 #1432
Merged
Merged
upgrade plotly to v2 #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
February 12, 2024 23:14
sumukhswamy
approved these changes
Feb 13, 2024
RyanL1997
approved these changes
Feb 16, 2024
mengweieric
added
the
Mend: dependency security vulnerability
Security vulnerability detected by Mend
label
Feb 19, 2024
mengweieric
approved these changes
Feb 19, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1432-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9750c82fce1387297b337a724a523c2c9b4dd59c
# Push it to GitHub
git push --set-upstream origin backport/backport-1432-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-1.3
# Create a new branch
git switch --create backport/backport-1432-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9750c82fce1387297b337a724a523c2c9b4dd59c
# Push it to GitHub
git push --set-upstream origin backport/backport-1432-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-1.3 Then, create a pull request where the |
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 9750c82)
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 9750c82)
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Feb 19, 2024
joshuali925
added a commit
that referenced
this pull request
Feb 19, 2024
joshuali925
added a commit
that referenced
this pull request
Feb 19, 2024
joshuali925
added a commit
that referenced
this pull request
Feb 19, 2024
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.3
backport 2.x
Mend: dependency security vulnerability
Security vulnerability detected by Mend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes CVE-2023-46308
i tested trace analytics and did some basic sanity tests and didn't see issues, but need owners to double check functionality and any breaking changes for the plotly major version upgrade https://github.com/plotly/plotly.js/releases/tag/v2.0.0
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.