Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix jaeger spans key names for filtering #1455

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2c1497b from #1428.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 2c1497b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (4c45cc5) 56.84% compared to head (37dad1b) 56.79%.

Files Patch % Lines
...trace_analytics/requests/traces_request_handler.ts 0.00% 22 Missing ⚠️
...analytics/components/traces/span_detail_flyout.tsx 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1455      +/-   ##
==========================================
- Coverage   56.84%   56.79%   -0.06%     
==========================================
  Files         318      318              
  Lines       11524    11543      +19     
  Branches     3005     3018      +13     
==========================================
+ Hits         6551     6556       +5     
- Misses       4921     4933      +12     
- Partials       52       54       +2     
Flag Coverage Δ
dashboards-observability 56.79% <35.13%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 17be4cd into 2.x Mar 6, 2024
20 of 32 checks passed
@github-actions github-actions bot deleted the backport/backport-1428-to-2.x branch March 6, 2024 23:59
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…ensearch-project#1455)

Signed-off-by: Craig Perkins <craig5008@gmail.com>
(cherry picked from commit 4902ef51509272be79be6e96c7ff2bb78f9d1934)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1455)

(cherry picked from commit 2c1497b)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 17be4cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants