[Backport 2.x] [Feature] Associated objects searchbar filters #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add associated objects filters for databases and accelerations Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix both filters Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix some UI details Signed-off-by: Ryan Liang <jiallian@amazon.com> * Finalize the UI details Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the acceleration filter type Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to lodash Signed-off-by: Ryan Liang <jiallian@amazon.com> * Enable multiple filter selections 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Make the filters logic into OR Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix some comments Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch back to JS instead of using lodash Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * Remove the inline style Signed-off-by: Ryan Liang <jiallian@amazon.com> * Set up an util file Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add a todo comment for dummy data Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * Address some minor comments Signed-off-by: Ryan Liang <jiallian@amazon.com> * Assign types for obj and clauses Signed-off-by: Ryan Liang <jiallian@amazon.com> * Setup the consts and replace them Signed-off-by: Ryan Liang <jiallian@amazon.com> * Finish an i18n example Signed-off-by: Ryan Liang <jiallian@amazon.com> * Finish the i18n for AO tab Signed-off-by: Ryan Liang <jiallian@amazon.com> * i18n done Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add jest test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 1b005d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
mengweieric
approved these changes
Mar 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1492 +/- ##
==========================================
+ Coverage 54.64% 54.73% +0.08%
==========================================
Files 340 341 +1
Lines 12047 12099 +52
Branches 3110 3121 +11
==========================================
+ Hits 6583 6622 +39
- Misses 5410 5424 +14
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
approved these changes
Mar 6, 2024
ps48
approved these changes
Mar 6, 2024
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…) (opensearch-project#1492) * Add associated objects filters for databases and accelerations * Fix both filters * Fix some UI details * Finalize the UI details * Fix the acceleration filter type * Switch to lodash * Enable multiple filter selections 1 * Make the filters logic into OR * Fix some comments * Switch back to JS instead of using lodash * Update the snapshots * Remove the inline style * Set up an util file * Add a todo comment for dummy data * Update the snapshots * Address some minor comments * Assign types for obj and clauses * Setup the consts and replace them * Finish an i18n example * Finish the i18n for AO tab * i18n done * Add jest test --------- (cherry picked from commit 1b005d4) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c67bcb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1b005d4 from #1474.