Update names and descriptions for integrations #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Swiddis
added
documentation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
added
backport 2.x
integrations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
- Coverage 54.28% 54.26% -0.03%
==========================================
Files 343 343
Lines 12342 12338 -4
Branches 3176 3173 -3
==========================================
- Hits 6700 6695 -5
- Misses 5586 5587 +1
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YANG-DB
approved these changes
Mar 6, 2024
ps48
approved these changes
Mar 7, 2024
|
Looks good! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Update branding for integrations Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Optimize image Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Better cropping for cloudfront logo Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 290415a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches names to the official product names instead of abbreviations, and updates the descriptions to clarify what the integration actually processes. Also found some logos without transparent backgrounds that were replaced and optimized.
I tried my best to use the product names from official documentation. Main concern is that WAF inconsistently switches between being called "AWS WAF" and "AWS Web Application Firewall", I went with the more verbose one.
Before:
After:
Issues Resolved
Closes #1461
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.