Integration override enabled #1833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…ates example Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…ncluding all its references IDs Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…ncluding all its references IDs Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…ncluding all its references IDs Signed-off-by: YANGDB <yang.db.dev@gmail.com>
YANG-DB
added
enhancement
YANG-DB
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo and
seankao-az
as code owners
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
|
What happens if you create two integrations with overriding, and delete one of the integrations? |
|
I will add a checkbox to indicate whether to override the dashboard id or not (similar to the savedObjects import dialog) so that the user will be aware
This is the same as with dashboards - the responsibility if on the user who is installing the integration template - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability for an integration's dashboards to use its original ID's to install .
It has the practical effect of
overridein the case where an older integration was already installedThis is to be accompanied with a UX checkbox to allow user's selection whether to generate new ID or use existing to override - exactly similar to the savedObject import dialog
Issues Resolved
#1731
#1835
opensearch-project/opensearch-catalog#170
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.