Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Adjustments Left Nav, Notebooks, Applications #2168

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Sep 13, 2024

Description

  1. Update the left navigation order.
  2. Update Overview cards to be lowercase/change wording
  3. Update Notebooks UI (Reduce table padding to 16 px, remove horizontal rule, add tooltips)
  4. Update Applications UI (Reduce table padding to 16px, remove horizontal rule, remove spacers, update config title)

Left navigation

Before After
Before Image 1 After Image 1

Card update

Before After
Before Image 1 After Image 1

Notebooks

Before After
Before Image 1 After Image 1
Before Image 2 After Image 2

Applications

Before After
Before Image 1 After Image 1
Before Image 2 After Image 2

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adam Tackett and others added 2 commits September 13, 2024 14:40
Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Sep 13, 2024
@TackAdam TackAdam marked this pull request as ready for review September 13, 2024 23:03
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulstn paulstn merged commit ce6fba4 into opensearch-project:main Sep 16, 2024
10 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* ui adjustments

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update getting started card footer

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit ce6fba4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Sep 16, 2024
(cherry picked from commit ce6fba4)

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants