Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderControl update style, UI Adjustments Integrations #2171

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Sep 17, 2024

Description

  1. Update plugin header control to use functionality for styling from core.
  2. Adjust the descriptions and links to use new header control functionality in notebooks and integrations.
  3. Small adjustment to applications to move button to header for the old navigation.
  4. Update integrations Cypress testing for new delete (just requires standard "delete" instead of application name following use pattern applied everywhere else).
  5. Update Integrations UI

~2 New Header control change (Buttons and Description field)

Before After
NotebookBefore NotebookAfter
IntegBefore IntegAfter

~4 Updated Cypress Testing
IntegCypress

~5 Integration Changes
a. Image on cards smaller
5aCards
b. Bulk delete
5bBulkDelete
c. Empty State
5cEmptyState
d. Underline Tabs
5dUnderlineTabs
e. Padding to 16px
5ePaddingAroundTable
f. Delete button secondary /hover
5fDeleteButtonSecondary:Hover
g. Panel added to Template text
5gPanelAdded
h. Remove Details / space between check new version
5hRemoveDetails:spaceOnNewVersions
i. Fix spelling
5iFixSpelling
h. Headings all adjusted to H3
5jH3HeadingsAllTitles

Integrations Before:
Screenshot 2024-09-17 at 11 47 21 AM
Screenshot 2024-09-17 at 11 43 59 AM
Screenshot 2024-09-17 at 11 44 09 AM
Screenshot 2024-09-17 at 11 44 24 AM

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Sep 17, 2024
@TackAdam TackAdam marked this pull request as ready for review September 17, 2024 18:50
Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam
Copy link
Collaborator Author

Updated based on comments / UI feedback pass
Cards images now 40x40
Screenshot 2024-09-17 at 2 08 15 PM
Text for secondary headers now h4 and bold
Screenshot 2024-09-17 at 2 07 51 PM
Screenshot 2024-09-17 at 2 08 04 PM
Lower case for the empty state "available list"
Screenshot 2024-09-17 at 2 08 36 PM

Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam TackAdam merged commit 929d67d into opensearch-project:main Sep 18, 2024
10 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* UI refactor, adjust headercontrolls

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* comments addressed, ui final feedback

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update name

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit 929d67d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam pushed a commit that referenced this pull request Sep 18, 2024
* UI refactor, adjust headercontrolls



* comments addressed, ui final feedback



* update name



---------



(cherry picked from commit 929d67d)

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants