Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Services Data Picker, UI Fixes #2177

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Sep 20, 2024

Description

  1. Bugfix for services data picker where declaring it twice was causing it to not render after closing fly-out and reset the selected data source to default. Also fix data source changing when navigation to traces through fly-out.
  2. UI fix to Metrics switched refresh button to icon for super date picker
  3. UI fix to overview page changing title of dashboard and adding ui link pop out icon

Bugfix:

Screen.Recording.2024-09-19.at.8.45.21.PM.mov

Metrics page after:
Screenshot 2024-09-19 at 8 58 43 PM

Before:
Screenshot 2024-09-19 at 9 06 50 PM

Overview page after:
Screenshot 2024-09-19 at 8 57 44 PM
Screenshot 2024-09-19 at 9 05 58 PM

Before:
Screenshot 2024-09-19 at 9 06 35 PM

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam TackAdam added bug Something isn't working backport 2.x labels Sep 20, 2024
Adam Tackett added 2 commits September 19, 2024 21:05
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
@TackAdam TackAdam marked this pull request as ready for review September 20, 2024 04:17
Adam Tackett added 2 commits September 19, 2024 21:22
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant