Initial commits for kicking off query editor implementations and datasource support

[mengweieric]

Description

Initial commits for creating basic shapes of query editor and datasource selection.

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #546 (ff75d5f) into feature/flint-UI (0c51ec2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/flint-UI     #546   +/-   ##
=================================================
  Coverage             42.85%   42.85%           
=================================================
  Files                   299      299           
  Lines                 17800    17800           
  Branches               4409     4361   -48     
=================================================
+ Hits                   7628     7629    +1     
+ Misses                10131    10130    -1     
  Partials                 41       41           

Flag	Coverage Δ
dashboards-observability	42.85% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[joshuali925]

lgtm, left some comments on the types, i find it hard to understand and change code without correct types, it would be easier if we can utilize type checks better

[joshuali925]

React.ReactNode?

[mengweieric]

Yes, later I'll compose more specific component type with props, this is in progress, but will add such type

[joshuali925]

probably for later but useCallback on onEditorChange function? since you are memorizing MonacoRawQueryEditor (and is it needed?)

[mengweieric]

Yes will add later now it's just a placeholder function here

[joshuali925]

np. add type for props?

[mengweieric]

Will add for sure, now it's not yet finalized what are the props it needs

[joshuali925]

np. possible to reduce the anys?..

[mengweieric]

yea like others, will avoid any all over the places, i've got more changes coming in for this, for now it's just placeholders

[joshuali925]

ideally

const QUERY_MODE_OPTIONS = [
  { label: 'Builder', id: 'visual_builder' },
  { label: 'Code', id: 'query_editor' },
] as const satisfies EuiButtonGroupOptionProps[];

export const QueryModeSwitcher = () => {
  const [toggleCompressedIdSelected, setToggleCompressedIdSelected] =
    useState<(typeof QUERY_MODE_OPTIONS)[number]['id']>('query_editor');

might be too much and not sure if OSD's typescript version supports satisfies

[mengweieric]

seems like not supported. but type EuiButtonGroupOptionProps[] makes sense

[joshuali925]

should Record<string, Datasource> be KeyValue<Datasource>?

[joshuali925]

when is this.components set?

[mengweieric]

this part is not added yet, coming up.

[mengweieric]

lgtm, left some comments on the types, i find it hard to understand and change code without correct types, it would be easier if we can utilize type checks better

Yes totally agreed. For this PR, many functions/components are not yet settled and under discussions/constructions, this PR is more for getting started with a feature branch then I'm able to keep posting smaller PRs that includes code that are really functioning, restricted with types and covered by tests.