Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Application Analytics - Save Visualization Missing Index #587

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

TackAdam
Copy link
Collaborator

Description

[Describe what this change achieves]
When saving a visualization from Application → Log Events / Visualizations it states it is saved correctly but appears on the panel page with the error "Issue in building final query" missing index. If you go to edit it from panels it opens up the visual as expected. Looking at the network request in panels the query is missing the source part. Appears to be a side effect of #449
Using the helper function buildRawQuery fixes it.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: TackAdam <navytackett@hotmail.com>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #587 (dbd1dc7) into main (dbb4a8a) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   43.12%   43.50%   +0.38%     
==========================================
  Files         303      305       +2     
  Lines       18008    18147     +139     
  Branches     4434     4453      +19     
==========================================
+ Hits         7766     7895     +129     
- Misses       9709     9717       +8     
- Partials      533      535       +2     
Flag Coverage Δ
dashboards-observability 43.50% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@TackAdam TackAdam merged commit 5fea6ab into opensearch-project:main Jun 30, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-587-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5fea6abec854b2eb757c54fc3a77b62a43b79563
# Push it to GitHub
git push --set-upstream origin backport/backport-587-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-587-to-2.x.

TackAdam added a commit to TackAdam/dashboards-observability that referenced this pull request Jul 6, 2023
[BugFix] Application Analytics - Save Visualization Missing Index

(cherry picked from commit 5fea6ab)
Signed-off-by: TackAdam <navytackett@hotmail.com>
TackAdam added a commit that referenced this pull request Jul 11, 2023
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
[BugFix] Application Analytics - Save Visualization Missing Index

(cherry picked from commit 5fea6ab)
Signed-off-by: TackAdam <navytackett@hotmail.com>
(cherry picked from commit d152aa4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants