Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Application Analytics - Panels not displaying availability #607

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 5, 2023

Description

[Describe what this change achieves]
Fixed a bug where the availability was not being displayed in panels as well as the data configuration. This was due to metaData for the user config not being parsed correctly and always being empty.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: TackAdam <navytackett@hotmail.com>
Signed-off-by: TackAdam <navytackett@hotmail.com>
Signed-off-by: TackAdam <navytackett@hotmail.com>
Signed-off-by: TackAdam <navytackett@hotmail.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #607 (7c80ce1) into main (14ec857) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #607    +/-   ##
========================================
  Coverage   43.42%   43.42%            
========================================
  Files         300      300            
  Lines       18113    18115     +2     
  Branches     4447     4401    -46     
========================================
+ Hits         7866     7867     +1     
- Misses       9712    10207   +495     
+ Partials      535       41   -494     
Flag Coverage Δ
dashboards-observability 43.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 77 files with indirect coverage changes

@derek-ho
Copy link
Collaborator

Can you backport to 2.x/2.9 if that's already created

@TackAdam TackAdam merged commit cd7bf38 into opensearch-project:main Jul 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-607-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cd7bf381e65101c873588fdd6e65f185a6e2d295
# Push it to GitHub
git push --set-upstream origin backport/backport-607-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-607-to-2.x.

TackAdam added a commit to TackAdam/dashboards-observability that referenced this pull request Jul 11, 2023
[BugFix] Application Analytics - Panels not displaying availability

(cherry picked from commit cd7bf38)
Signed-off-by: TackAdam <navytackett@hotmail.com>
TackAdam added a commit that referenced this pull request Jul 11, 2023
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
[BugFix] Application Analytics - Panels not displaying availability

(cherry picked from commit cd7bf38)
Signed-off-by: TackAdam <navytackett@hotmail.com>
(cherry picked from commit f6b9180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants