Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert integrations change metrics #672

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jul 14, 2023

Description

#638
metrics constant file was broken due to this PR, there was this typescript error that was ignored. we should make CI fail on typescript errors

Diagnostics:
Property 'forEach' does not exist on type '"application_analytics" | "operational_panels" | "event_analytics" | "notebooks" | "trace_analytics" | "metrics_analytics" | "integrations"'.
  Property 'forEach' does not exist on type '"application_analytics"'. [2339]

This PR fixes the metrics constant file by restoring the previous version, probably broken due to merge conflict

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk

@anirudha anirudha merged commit 8c12cba into opensearch-project:2.9 Jul 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-672-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c12cba5a5bda17f0b4675db1a84638319a5e3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-672-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-672-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-672-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c12cba5a5bda17f0b4675db1a84638319a5e3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-672-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-672-to-main.

derek-ho pushed a commit to derek-ho/dashboards-observability that referenced this pull request Jul 14, 2023
…ns-metrics

(cherry picked from commit 8c12cba)
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho pushed a commit to derek-ho/dashboards-observability that referenced this pull request Jul 14, 2023
…ns-metrics

(cherry picked from commit 8c12cba)
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho added a commit that referenced this pull request Jul 17, 2023
(cherry picked from commit 8c12cba)
Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ns-metrics (opensearch-project#673)

(cherry picked from commit 8c12cba)
Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
(cherry picked from commit 6d4e100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants