-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert integrations change metrics #672
revert integrations change metrics #672
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-672-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c12cba5a5bda17f0b4675db1a84638319a5e3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-672-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-672-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c12cba5a5bda17f0b4675db1a84638319a5e3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-672-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
…ns-metrics (cherry picked from commit 8c12cba) Signed-off-by: Derek Ho <dxho@amazon.com>
…ns-metrics (cherry picked from commit 8c12cba) Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 8c12cba) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
…ns-metrics (opensearch-project#673) (cherry picked from commit 8c12cba) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu> (cherry picked from commit 6d4e100)
Description
#638
metrics constant file was broken due to this PR, there was this typescript error that was ignored. we should make CI fail on typescript errors
This PR fixes the metrics constant file by restoring the previous version, probably broken due to merge conflict
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.