[BACKPORT] Router fix from 2.9 to 2.x #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge Kibana backend from osints/dev into main (opensearch-project#565) * Merge in kibana backend from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add integration type to .kibana from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add license header Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix integrations type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra test files Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
|
@Swiddis can you rebase from 2.x, I just pulled in the typescript change so CI should pass after that |
Codecov Report
@@ Coverage Diff @@
## 2.x #683 +/- ##
==========================================
+ Coverage 43.05% 43.51% +0.46%
==========================================
Files 309 313 +4
Lines 18386 18616 +230
Branches 4452 4489 +37
==========================================
+ Hits 7916 8101 +185
- Misses 10428 10473 +45
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. |
YANG-DB
approved these changes
Jul 28, 2023
|
Do we need this in main as well? |
ps48
approved these changes
Jul 28, 2023
It's already in |
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…pensearch-project#683) * Merge Kibana backend from osints/dev into main (opensearch-project#565) * Merge in kibana backend from osints/dev * Add integration type to .kibana from osints/dev * Re-add license header * Fix integrations type --------- * Remove extra test files --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit ad2c5f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #680
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.