-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move schema files to centralized catalog #774
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
server/adaptors/integrations/__data__/catalog/logs_vpc-1.0.0.mapping.json
Outdated
Show resolved
Hide resolved
server/adaptors/integrations/__data__/catalog/aws_s3-1.0.0.mapping.json
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 43.66% 43.65% -0.01%
==========================================
Files 312 312
Lines 18587 18587
Branches 4479 4480 +1
==========================================
- Hits 8116 8115 -1
- Misses 10429 10430 +1
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
server/adaptors/integrations/__data__/catalog/observability/logs/logs_vpc-1.0.0.mapping.json
Outdated
Show resolved
Hide resolved
@@ -4,7 +4,7 @@ | |||
"displayName": "AWS VPC Flow", | |||
"description": "AWS VPC Flow log collector", | |||
"license": "Apache-2.0", | |||
"type": "logs", | |||
"type": "logs_vpc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the logs
index based integrations should use the same index template names logs
the only dynamic things that should be integration specific are:
- index alias
composed_of
component list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that we need to work with these duplicates for now to account for multiple component configs. Let's work on fixing it later, as a hacky solution I can try setting the composed_of list dynamically, but I want to keep this PR small
server/adaptors/integrations/__data__/repository/nginx/nginx-1.0.0.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Todo: Update front-end display to trim leading directories from categories. Actual: If you open the VPC integration you'll see the categories listed as Expected: Trim leading directories for |
Status update: Postponing to after we're done with 2.9 release. This is a hefty refactor and will need some time to get done right. Will leave it as a draft for now, we can revisit it in a month or so. |
resolved in opensearch-project/opensearch-catalog#69 |
Description
Per side-channel discussion, we realized that it's going to block integration development if we need to keep our schemas in sync with each other everywhere. This PR centralizes the catalog files so that variations in schemas can be better tracked. This is a stand-in solution until the catalog API is available at
opensearch-catalog
.Following this PR, the following process for updating catalog files is advised:
opensearch-catalog
.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.