Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add materlized views, manual refresh option and minor fixes #159

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Add materlized views, manual refresh option and minor fixes #159

merged 5 commits into from
Oct 18, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 17, 2023 •
edited
Loading

Description

  1. Add materialized view option
  2. remove fill from accelerate table button
  3. Add manual refresh option
  4. Update copy for data sources
  5. Fix redirection issue to acceleration flyout
  6. Update tests

Issues Resolved

#127
Depends on opensearch-project/opensearch-spark#73

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 added 3 commits October 17, 2023 14:09
@ps48
enable materialized views, update acc btn fill
09cac73 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
update acceleration links
16b8490 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
add manual refresh option, update tests
0b295c7 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 marked this pull request as draft October 17, 2023 23:05
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #159 (9a34f6d) into main (8409ef7) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   54.72%   54.51%   -0.22%     
==========================================
  Files          33       33              
  Lines        1365     1385      +20     
  Branches      216      220       +4     
==========================================
+ Hits          747      755       +8     
- Misses        537      546       +9     
- Partials       81       84       +3
Flag Coverage Δ
dashboards-query-workbench 54.51% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

ps48 added 2 commits October 17, 2023 16:29
@ps48
update copy for datasources
b782d02 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
fix redirection issue
9a34f6d 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 marked this pull request as ready for review October 18, 2023 18:17
derek-ho
derek-ho reviewed Oct 18, 2023
View reviewed changes
public/components/SQLPage/SQLPage.tsx
@@ -37,6 +37,8 @@ interface SQLPageProps {
sqlTranslations: ResponseDetail<TranslateResult>[];
selectedDatasource: EuiComboBoxOptionOption[];
asyncLoading: boolean;
openAccelerationFlyout: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to something like isAccelerationFlyoutOpen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isAccelerationFlyoutOpen doesn't make much sense as a name here. This prop dictates should be acceleration flyout be opened or not by the SQL page component.
ex:

if parent props sends value openAccelerationFlyout={true} -> the child component opens the flyout

derek-ho
derek-ho reviewed Oct 18, 2023
View reviewed changes
public/components/Main/main.tsx
Comment on lines +830 to +831
openAccelerationFlyout={
this.props.isAccelerationFlyoutOpen && !this.state.isAccelerationFlyoutOpened
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get why these two booleans are used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is for the prop which dictates if URL has a datasource that needs to be open with acceleration flyout. The other is to keep a local state. We need the local state to make sure, the URL flyout only opens once.

@ps48 ps48 merged commit 43b085b into opensearch-project:main Oct 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
Add materlized views, manual refresh option and minor fixes (#159)
f620913 
* enable materialized views, update acc btn fill

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update acceleration links

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add manual refresh option, update tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update copy for datasources

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix redirection issue

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 43b085b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 18, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
Add materlized views, manual refresh option and minor fixes (#159)
7abecbe 
* enable materialized views, update acc btn fill

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update acceleration links

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add manual refresh option, update tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update copy for datasources

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix redirection issue

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 43b085b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 18, 2023
@opensearch-trigger-bot @github-actions
Add materlized views, manual refresh option and minor fixes (#159) (#160
cf4a4d6 
)

* enable materialized views, update acc btn fill



* update acceleration links



* add manual refresh option, update tests



* update copy for datasources



* fix redirection issue



---------


(cherry picked from commit 43b085b)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 18, 2023
@opensearch-trigger-bot @github-actions
Add materlized views, manual refresh option and minor fixes (#159) (#161
88970fb 
)

* enable materialized views, update acc btn fill



* update acceleration links



* add manual refresh option, update tests



* update copy for datasources



* fix redirection issue



---------


(cherry picked from commit 43b085b)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 13, 2023
@mengweieric
Revert "Add materlized views, manual refresh option and minor fixes (o…
efb347d 
…pensearch-project#159) (opensearch-project#161)"

This reverts commit 88970fb.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric mengweieric mentioned this pull request Nov 13, 2023
Merged
6 tasks
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert "Add materlized views, manual refresh option and minor fixes (#…
da998e6 
…159) (#161)" (#212)

This reverts commit 88970fb.

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derek-ho derek-ho derek-ho left review comments

@kavithacm kavithacm kavithacm approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps48 @kavithacm @derek-ho @YANG-DB