[Manual Backport 2.x] Run Cypress integration tests on build (#143) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
requested review from
macohen,
mingshl,
msfroh and
sejli
as code owners
noCharger
changed the title
noCharger
changed the title
noCharger
changed the title
noCharger
changed the title
noCharger
force-pushed
the
backport-143-to-2.x
branch
from
f5372c1
to
f48fee0
Compare
Run the Cypress integration tests as a GitHub action on every build, to better catch regressions. Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 2ef265d)
noCharger
force-pushed
the
backport-143-to-2.x
branch
from
f48fee0
to
9f5477b
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #205 +/- ##
==========================================
+ Coverage 81.42% 86.27% +4.84%
==========================================
Files 13 15 +2
Lines 140 204 +64
Branches 27 40 +13
==========================================
+ Hits 114 176 +62
- Misses 24 26 +2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sejli
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the Cypress integration tests as a GitHub action on every build, to better catch regressions.
Signed-off-by: Michael Froh froh@amazon.com
(cherry picked from commit 2ef265d)
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.