Changing select index error message to be more informative (#173) #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#173) Signed-off-by: Evan Kielley <evankielley@gmail.com>
evankielley
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
|
@evankielley Thank you for your contribution to the DSR plugin! Could please add a screenshot of the page before and after the changes. Also, the identical error message appears in multiple files; can we make it a constant? Please disregard the yarn.lock file change. The maintainers are addressing it now. |
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 15 15
Lines 204 204
Branches 40 40
=======================================
Hits 176 176
Misses 26 26
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
No problem, will do! |
…opensearch-project#173) Signed-off-by: Evan Kielley <evankielley@gmail.com>
|
Ready for re-review |
Oh nice. Will do. Sorry I forgot that earlier. |
Signed-off-by: Evan Kielley <evankielley@gmail.com>
|
Ready |
The jar hell issue should be resolved after the new artifacts for OpenSearch core are available. Merge this PR now. |
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2023
* Changing select index error message to be more informative (#173) Signed-off-by: Evan Kielley <evankielley@gmail.com> * Changing select index error message to be a constant to keep code DRY (#173) Signed-off-by: Evan Kielley <evankielley@gmail.com> * Reverting change to yarn.lock Signed-off-by: Evan Kielley <evankielley@gmail.com> --------- Signed-off-by: Evan Kielley <evankielley@gmail.com> (cherry picked from commit dff6559) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Sep 5, 2023
…) (#275) * Changing select index error message to be more informative (#173) * Changing select index error message to be a constant to keep code DRY (#173) * Reverting change to yarn.lock --------- (cherry picked from commit dff6559) Signed-off-by: Evan Kielley <evankielley@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user submits a search query with no index or only one index selected, an error message is displayed that tells the user to select an index. This pull request changes that error message to be more informative.
Issues Resolved
Resolves #173
Screenshots
Before
(Before) Both left and right indices selected
(Before) Only left index selected
(Before) Only right index selected
(Before) Neither left nor right indices selected
After
(After) Both left and right indices selected
(After) Only left index selected
(After) Only right index selected
(After) Neither left nor right indices selected
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.