[Backport 2.x] Adding error message in Search Comparison Tool #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* adding error message in search comparison tool Signed-off-by: Sean Li <lnse@amazon.com> * updating test snapshots Signed-off-by: Sean Li <lnse@amazon.com> * adding tests for query error Signed-off-by: Sean Li <lnse@amazon.com> * updating tests Signed-off-by: Sean Li <lnse@amazon.com> * refactoring QueryError, adding error message to result panel Signed-off-by: Sean Li <lnse@amazon.com> * moving helper text to helpText prop Signed-off-by: Sean Li <lnse@amazon.com> * adding tests and addressing comments Signed-off-by: Sean Li <lnse@amazon.com> * adding more tests, fixing state management, addressing comments Signed-off-by: Sean Li <lnse@amazon.com> * reverting changes to validateQuery, addressing comments Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit 6fb31c8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions
bot
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
sejli
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6fb31c8 from #267.