Utilize EuiEmptyPrompt to represent empty state #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
nung22
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 16 16
Lines 209 209
Branches 43 43
=======================================
Hits 182 182
Misses 26 26
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Could you add screenshots for when sample data has already been added to the OpenSearch cluster? |
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
I updated the content of the empty prompt after a discussion on the #257 thread:
|
joshuarrrr
reviewed
Oct 11, 2023
public/components/query_compare/search_result/result_components/result_components.tsx
Outdated
Show resolved
Hide resolved
…s/result_components.tsx Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 17, 2023
* Utilize EuiEmptyPrompt to represent empty state Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update icon and text for empty prompts Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update public/components/query_compare/search_result/result_components/result_components.tsx Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 53d6fe3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Utilize EuiEmptyPrompt to represent empty state * Update icon and text for empty prompts * Update public/components/query_compare/search_result/result_components/result_components.tsx --------- (cherry picked from commit 53d6fe3) Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
EuiEmptyPromptcomponent to represent empty state in the result panel of Search Relevance. "Connect to data source" button links to thetutorial_directoryendpoint so users can add sample data if they wish.Issues Resolved
Closes #308
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screenshots
Before:
Dark Mode
Light Mode
After:
Dark Mode
Light Mode
Navigation to "Add Sample Data" page:
Dark Mode
Light Mode