Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap user-facing strings for internalization #334

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 27, 2023

  1. Squashed commit of the following:

    commit 7e11c9f
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 17:27:21 2023 -0700
    
        Resolve id and unique key errors
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit 58f5ac7
    Merge: e9b6894 fde4421
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 17:12:18 2023 -0700
    
        Merge branch 'refactor/issue-330' of https://github.com/nung22/dashboards-search-relevance into refactor/issue-330
    
    commit e9b6894
    Merge: 13f9246 e92057a
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 17:08:49 2023 -0700
    
        Wrap all repo tests with I18nProvider
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit fde4421
    Merge: 13f9246 e92057a
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 17:08:49 2023 -0700
    
        Merge branch 'refactor/issue-330' of https://github.com/nung22/dashboards-search-relevance into refactor/issue-330
    
    commit 13f9246
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 16:59:05 2023 -0700
    
        Wrap all repo tests with I18nProvider
    
    commit e92057a
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 16:59:05 2023 -0700
    
        Wrap test with I18nProvider
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit 2b9c0ea
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 16:40:25 2023 -0700
    
        Update duplicate ids in flyout.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit 7d14e3c
    Merge: 6869944 bbb27f4
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Thu Oct 26 10:52:55 2023 -0700
    
        Merge branch 'refactor/issue-330' of https://github.com/nung22/dashboards-search-relevance into refactor/issue-330
    
    commit 6869944
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Wed Oct 25 14:35:32 2023 -0700
    
        Refactor code for user-wrapped strings in header.tsx and flyout.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit b69ff41
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 15:06:05 2023 -0700
    
        Wrap user-facing strings in header.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit fe99311
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 14:09:06 2023 -0700
    
        Update flyout.tsx snapshot
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit 7a2a97a
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 14:03:12 2023 -0700
    
        Update FormattedMessages blocks in flyout.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit c58a10b
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Tue Oct 17 10:11:15 2023 -0700
    
        Wrap user-facing strings in flyout.tsx for internalization
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit bbb27f4
    Merge: 38162ca 77db981
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 17:00:01 2023 -0700
    
        Merge branch 'main' of https://github.com/nung22/dashboards-search-relevance into refactor/issue-330
    
    commit 38162ca
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 15:06:05 2023 -0700
    
        Wrap user-facing strings in header.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit a7ce8f6
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 14:09:06 2023 -0700
    
        Update flyout.tsx snapshot
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit c1cd4fa
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Mon Oct 23 14:03:12 2023 -0700
    
        Update FormattedMessages blocks in flyout.tsx
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    commit 611546a
    Author: Nicholas Ung <nicholasung22@gmail.com>
    Date:   Tue Oct 17 10:11:15 2023 -0700
    
        Wrap user-facing strings in flyout.tsx for internalization
    
        Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    
    Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    nung22 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a231956 View commit details
    Browse the repository at this point in the history
  2. Update test for flyout.tsx and header.tsx

    Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    nung22 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d213d8e View commit details
    Browse the repository at this point in the history
  3. Reformat EuiCode wrappers in flyout.tsx

    Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    nung22 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e130d29 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    4ab6aa1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    498b973 View commit details
    Browse the repository at this point in the history
  3. Update flyout.tsx test

    Signed-off-by: Nicholas Ung <37952714+nung22@users.noreply.github.com>
    nung22 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b4906dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73ab192 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Update header.tsx and flyout.tsx

    Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
    nung22 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a77bfa7 View commit details
    Browse the repository at this point in the history