Add new S3 source option and modify docdb template #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srigovs <srigovs@amazon.com>
srikanthjg
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
approved these changes
May 2, 2024
| @@ -189,4 +192,8 @@ public Map<String, String> getBucketOwners() { | |||
| public String getDefaultBucketOwner() { | |||
| return defaultBucketOwner; | |||
| } | |||
|
|
|||
| public boolean isDeleteS3MetadataInEvent() { | |||
| return deleteS3MetadataInEvent; | |||
There was a problem hiding this comment.
Nit: variable and function rename to disableS3MetadataInEvent;
| scan: | ||
| folder_partitions: |
There was a problem hiding this comment.
Would be nice if we added an integration test for the transform. Not needed in this PR
kkondaka
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new S3 source option
disable_s3_metadata_in_event: trueoption will not add bucket name and key to event.Modify docdb template
Added
disable_s3_metadata_in_eventandfolder_partitionsoptions in s3 scan of doc db templateCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.