Modify AcknowledgementSet add API to accept EventHandle instead of Event #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 17, 2024
| * @since 2.2 | ||
| */ | ||
| public void add(Event event); | ||
| public void add(EventHandle eventHandle); |
There was a problem hiding this comment.
Why not support both for now?
There was a problem hiding this comment.
Because it is not required. Do you mean we should support it just so the number of code changes would be less? If that matters, we could support both.
There was a problem hiding this comment.
Modified to support both using a default method in the interface.
| eventHandle.addAcknowledgementSet(acknowledgementSet1); | ||
| eventHandle.addAcknowledgementSet(acknowledgementSet2); | ||
| AggregateEventHandle eventHandle2 = new AggregateEventHandle(now); | ||
| doNothing().when(acknowledgementSet1).add(any(EventHandle.class)); |
There was a problem hiding this comment.
I don't think you need these doNothing() calls. This should be the default.
| @@ -452,7 +452,7 @@ private void processRecord(final AcknowledgementSet acknowledgementSet, final Re | |||
| // buffer contents before the event record is added | |||
| // to acknowledgement set | |||
| if (acknowledgementSet != null) { | |||
| acknowledgementSet.add(record.getData()); | |||
| acknowledgementSet.add(((Event)record.getData()).getEventHandle()); | |||
There was a problem hiding this comment.
If we continue to support add(Event) then all of this code should be simpler and you can remove for this PR.
| acknowledgementSet = mock(AcknowledgementSet.class); | ||
| eventHandle.addAcknowledgementSet(acknowledgementSet); | ||
| DefaultEventHandle eventHandle2 = new DefaultEventHandle(now); | ||
| doNothing().when(acknowledgementSet).add(any(EventHandle.class)); |
There was a problem hiding this comment.
I don't think you need this line.
| totalEventsAdded.incrementAndGet(); | ||
| } | ||
| InternalEventHandle internalEventHandle; | ||
| if (eventHandle instanceof AggregateEventHandle) { |
There was a problem hiding this comment.
Why do you have this condition?
These lines should just become:
InternalEventHandle internalEventHandle = (InternalEventHandle) eventHandle;
30b46c6 to
95d0d7d
Compare
added 2 commits
October 17, 2024 21:19
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
force-pushed
the
ackset-with-eventhandle
branch
from
87bbd60 to
aa3e2d5
Compare
added 3 commits
October 17, 2024 21:29
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
dlvenable
previously approved these changes
Oct 18, 2024
oeyh
previously approved these changes
Oct 18, 2024
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
added 2 commits
October 18, 2024 18:10
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
dlvenable
approved these changes
Oct 21, 2024
oeyh
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify AcknowledgementSet add API to accept EventHandle instead of Event.
This is part of supporting acknowledgements in aggregate processor (local mode).
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.