Adding defaultValue to the @JsonProperty for processors. #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
oeyh
as code owners
chenqi0805
approved these changes
Oct 17, 2024
| @@ -93,7 +93,7 @@ public class GrokProcessorConfig { | |||
| "<code>pattern_directories</code>. Default is <code>*</code>.") | |||
| private String patternsFilesGlob = DEFAULT_PATTERNS_FILES_GLOB; | |||
|
|
|||
| @JsonProperty(TIMEOUT_MILLIS) | |||
| @JsonProperty(value = TIMEOUT_MILLIS, defaultValue = "30000") | |||
There was a problem hiding this comment.
Is it possible to reuse DEFAULT_TIMEOUT_MILLIS in the defaultValue?
graytaylor0
approved these changes
Oct 17, 2024
| @@ -39,7 +39,7 @@ public class AggregateProcessorConfig { | |||
| private PluginModel aggregateAction; | |||
|
|
|||
| @JsonPropertyDescription("The amount of time that a group should exist before it is concluded automatically. Supports ISO_8601 notation strings (\"PT20.345S\", \"PT15M\", etc.) as well as simple notation for seconds (\"60s\") and milliseconds (\"1500ms\"). Default value is 180s.") | |||
| @JsonProperty("group_duration") | |||
| @JsonProperty(value = "group_duration", defaultValue = DEFAULT_GROUP_DURATION_SECONDS + "s") | |||
There was a problem hiding this comment.
We don't need string conversion of DEFAULT_GROUP_DURATION_SECONDS here?
There was a problem hiding this comment.
The default value itself is 180s because it is a duration value.
san81
pushed a commit
to san81/data-prepper
that referenced
this pull request
Oct 17, 2024
…project#5080) Signed-off-by: David Venable <dlv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates processors to use
@JsonProperty'sdefaultValueto improve documentation.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.